Fix getmasternodeblocks depth filtering #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcorral
requested review from
Bushstar,
Mixa84,
monstrobishi and
uzyn
as code owners
bvbfan
previously approved these changes
Dec 7, 2021
Restore int behaviour pre-FCM
Restore owner calc behaviour
surangap
previously approved these changes
Dec 9, 2021
surangap
reviewed
Dec 13, 2021
There was a problem hiding this comment.
Please hold until BirthdayResearch/jellyfishsdk#861 (review) is resolved.
Fix wrong number of openVaults and openAuctions in getloaninfo
Signed-off-by: Anthony Fieroni <[email protected]>
Factor out usage of height field in CBlockIndex and CBlockHeader
Jellyfish test passed. can continue to merge. |
Adds possibility to use "*" to auto-select address in placeauctionbid and paybackloan
Co-authored-by: Prasanna Loganathar <[email protected]>
* Rework mempool accounts view Signed-off-by: Anthony Fieroni <[email protected]> Co-authored-by: Prasanna Loganathar <[email protected]>
|
Actual diff: 4801205...fix/getmasternodeblocks-depth |
Jouzo
pushed a commit
that referenced
this pull request
Dec 30, 2021
* Fix getmasternodeblocks depth filtering
Bushstar
added a commit
that referenced
this pull request
Jan 4, 2022
* Adds possibility to use "*" to auto-select address in placeauctionbid and paybackloan * Reduce complexity by throwing first if isNull * Remove dangling brace * Fix test assertion * Remove print in tests * Use nHeight as height field may be incorrect * Factor out usage of height field in block header * Factor out usage of height field in CBlockIndex * Add start BTC height and record limit to spv_listanchors (#921) Co-authored-by: Prasanna Loganathar <[email protected]> * Rework mempool accounts view (#904) * Rework mempool accounts view Signed-off-by: Anthony Fieroni <[email protected]> Co-authored-by: Prasanna Loganathar <[email protected]> * Fix getmasternodeblocks depth filtering (#946) * Fix getmasternodeblocks depth filtering * Enable composite swap for `testpoolswap` (#954) * Add support for composite swap in `testpoolswap` Co-authored-by: jouzo <[email protected]> Co-authored-by: Prasanna Loganathar <[email protected]> * Version 2.3.2 (#1000) * Fix excess logging of composite swap (#1003) * Add support for test only composite swap without balance transfers (#1004) * Add support for test only composite swap without balance transfers * Add CalculateSwap testonly support * Adds FortCanningHillHeight (#1005) * Adds FortCanningHillHeight Co-authored-by: Jouzo <[email protected]> * Disable ICX - Version 2.4.0 (#1010) * Disable ICX * Set Fort Canning Park height Signed-off-by: Anthony Fieroni <[email protected]> Co-authored-by: Anthony Fieroni <[email protected]> * Add checkpoint (#1013) Co-authored-by: jouzo <[email protected]> Co-authored-by: Prasanna Loganathar <[email protected]> Co-authored-by: Peter Bushnell <[email protected]> Co-authored-by: Anthony Fieroni <[email protected]> Co-authored-by: Mambisi Zempare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind fix
What this PR does / why we need it:
Fixes depth filtering in
getmasternodeblocksRPCWhich issue(s) does this PR fixes?:
Fixes #944 #718