Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rpc_vault HelpExampleRpc messages #881

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Conversation

Jouzo
Copy link
Collaborator

@Jouzo Jouzo commented Nov 8, 2021

What kind of PR is this?:

/kind chore

What this PR does / why we need it:

Fix vault RPCs HelpExampleRpc messages

This should be used as base for futur HelpExampleRpc messages as none of the previous one were working as is.
A user should be able to copy and paste from the example message to try the command.

@prasannavl prasannavl merged commit 9d1e70b into 2.0.x Nov 8, 2021
@prasannavl prasannavl deleted the fix/vault_help_examples branch November 8, 2021 15:50
@prasannavl prasannavl restored the fix/vault_help_examples branch November 8, 2021 16:54
prasannavl added a commit that referenced this pull request Nov 8, 2021
prasannavl added a commit that referenced this pull request Nov 8, 2021
* Fix HelpExampleRpc messages (#881)
* Revert "Fix HelpExampleRpc messages (#881)"

Co-authored-by: Jouzo <[email protected]>
@prasannavl prasannavl deleted the fix/vault_help_examples branch April 10, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants