Including tx fee into block rewards #752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShengguangXiao
requested review from
Bushstar,
bvbfan,
Mixa84,
monstrobishi,
surangap and
uzyn
as code owners
ShengguangXiao
force-pushed
the
fix/include-txfee-to-miner-rewards
branch
from
672d779 to
e377b81
Compare
bvbfan
suggested changes
Sep 27, 2021
| @@ -239,7 +239,7 @@ std::unique_ptr<CBlockTemplate> BlockAssembler::CreateNewBlock(const CScript& sc | |||
| coinbaseTx.vout.resize(2); | |||
|
|
|||
| // Explicitly set miner reward | |||
| coinbaseTx.vout[0].nValue = CalculateCoinbaseReward(blockReward, consensus.dist.masternode); | |||
| coinbaseTx.vout[0].nValue = nFees + CalculateCoinbaseReward(blockReward, consensus.dist.masternode); | |||
There was a problem hiding this comment.
It should be covered by hardfork height
There was a problem hiding this comment.
The validation should still pass even without fork height.
Line 2065 in 6059de0
There was a problem hiding this comment.
If we go without hardfork, newer nodes will generate bigger reward than older one, It's inconstancy.
There was a problem hiding this comment.
I will make the change in another PR based on 1.9.x.
#764
|
Close this in favor of #764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind fix
What this PR does / why we need it:
Tx fees not included in the block rewards
Which issue(s) does this PR fixes?:
Fixes #
https://github.com/cakedefi/defichain-private/issues/681
Additional comments?: