-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split make.sh build, fix lints, cleanup #751
Conversation
So this change will use GCC as the default compiler again? Should we check the minimum GCC version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GCC version should be 10.3 or Clang due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68070
More PRs coming soon. Base updates that push the gcc up, and have better consistency to use the same compilers for CI tests and builds. This change doesn't affect the CI builds though. The docker images still use clang. It only affects local builds. |
|
/kind refactor
EXTRA_MAKE_ARGS => MAKE_ARGS
EXTRA_MAKE_CONF_ARGS => MAKE_CONF_ARGS
EXTRA_MAKE_DEPENDS_ARGS => MAKE_DEPS_ARGS
MAKE_JOBS
var to target all parallel jobs at once.MAKE_DEBUG
var as convenience to get debug builds (suffixes MAKE_CONF_ARGS with--enable-debug
)MAKE_COMPILER
that prepends the compiler flags to MAKE_CONF_ARGS, defaults to clang.HOST
to depends so target is carried forward to keep it platform agnostic (even though we don't really use this anywhere else)