Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show untrusted txs in account history #711

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

bvbfan
Copy link
Contributor

@bvbfan bvbfan commented Sep 3, 2021

ShengguangXiao
ShengguangXiao previously approved these changes Sep 3, 2021
Copy link
Member

@prasannavl prasannavl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about about making trusted an optional parameter? And so probably good to have the default to false, so there are no incompatibilities.

@bvbfan
Copy link
Contributor Author

bvbfan commented Sep 7, 2021

listtransations can be used to see all txs, here is better to not have untrusted

@prasannavl
Copy link
Member

I see your point. Let's merge it into 1.9.x / 2.0 branch instead since this is a breaking change.

@bvbfan
Copy link
Contributor Author

bvbfan commented Sep 9, 2021

Sure it's best candidate to 2.0

@prasannavl prasannavl changed the base branch from master to 2.0.x October 22, 2021 12:39
@prasannavl prasannavl dismissed ShengguangXiao’s stale review October 22, 2021 12:39

The base branch was changed.

@prasannavl prasannavl merged commit 214a777 into 2.0.x Oct 22, 2021
@prasannavl prasannavl deleted the fix/do_not_show_untrusted_tx branch October 22, 2021 13:25
prasannavl pushed a commit that referenced this pull request Oct 30, 2021
prasannavl pushed a commit that referenced this pull request Oct 30, 2021
prasannavl pushed a commit that referenced this pull request Oct 30, 2021
prasannavl pushed a commit that referenced this pull request Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants