Ocean: fix rm/update oracle index #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canonbrother
force-pushed
the
canonbrother/fix-rm-oracle-index
branch
from
82cd86b to
434a558
Compare
canonbrother
changed the title
canonbrother
force-pushed
the
canonbrother/fix-rm-oracle-index
branch
from
434a558 to
0887c5f
Compare
canonbrother
force-pushed
the
canonbrother/fix-rm-oracle-index
branch
2 times, most recently
from
1206e36 to
363ed1a
Compare
canonbrother
commented
Nov 4, 2024
| @@ -184,7 +184,7 @@ fn create_new_bucket( | |||
|
|
|||
| impl IndexBlockStart for PoolSwap { | |||
| fn index_block_start(self, services: &Arc<Services>, block: &BlockContext) -> Result<()> { | |||
| let mut pool_pairs = services.pool_pair_cache.get(); | |||
There was a problem hiding this comment.
revert as breaking poolpair.swap.split.defid.ts test
canonbrother
requested review from
Bushstar,
prasannavl and
Jouzo
as code owners
Jouzo
approved these changes
Nov 4, 2024
Bushstar
pushed a commit
that referenced
this pull request
Nov 5, 2024
* Ocean tries to catchup on startup if below tip height * Keep hold of lock * Fix RemoveOracle indexing * Small perf improvements * Revert "Keep hold of lock" This reverts commit 07552f7. * Create base txid out of loop * Fix printf args order * Don't hold ocean invalidation * Revert "Revert "Keep hold of lock"" This reverts commit 29a423c. * Bump setgovheight dftx buffer size * Ocean: fix rm/update oracle index (#3107) * fix * update ocean ci * revert to direct ffi:get_pp * Remove clone --------- Co-authored-by: canonbrother <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary