fix: revert wrong refactor of GetLoanTokensForFutures #3039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During the restart PR, the method
GetLoanTokensForFutures
was copied toGetLoanTokensForLocks
. This method was later simplified cause the "old way" of getting loan tokens is not needed for the restart case. With this refactor, the GetLoanTokensForFutures was simplified the same way which leads to errors in FutureSwaps before the loanTokens moved to attributes.This PR fixes this by reverting the change in the GetLoanTokensForFutures method.
nodes with existing data on changi should be fine with the fork. I guess this fix is only needed to make the full reindex work again.
Implications
Storage
Consensus