Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert wrong refactor of GetLoanTokensForFutures #3039

Merged

Conversation

kuegi
Copy link
Contributor

@kuegi kuegi commented Sep 6, 2024

Summary

During the restart PR, the method GetLoanTokensForFutures was copied to GetLoanTokensForLocks. This method was later simplified cause the "old way" of getting loan tokens is not needed for the restart case. With this refactor, the GetLoanTokensForFutures was simplified the same way which leads to errors in FutureSwaps before the loanTokens moved to attributes.

This PR fixes this by reverting the change in the GetLoanTokensForFutures method.

nodes with existing data on changi should be fine with the fork. I guess this fix is only needed to make the full reindex work again.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl
Copy link
Member

prasannavl commented Sep 7, 2024

Merging to set a pre-release for changi candidates to update to in-time. Release to be set after https://github.com/DeFiCh/ain/actions/runs/10747073649 passes.

Edit: https://github.com/DeFiCh/ain/actions/runs/10747313308

@prasannavl prasannavl merged commit 95febdf into DeFiCh:master Sep 7, 2024
15 of 28 checks passed
@kuegi kuegi deleted the fix/revert-loantokensfutures-refactor branch September 10, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants