Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Refactor trace tx pipeline into executor #2824

Merged
merged 8 commits into from
Feb 23, 2024
Merged

EVM: Refactor trace tx pipeline into executor #2824

merged 8 commits into from
Feb 23, 2024

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Feb 18, 2024 •
edited
Loading

Summary

  • Resolves issue raised in evm: eth_createAccessList #2770 (comment)
  • Shifts execution tx with trace into ain executor. EVM executor instance should be abstracted from caller and inside ain executor with this PR refactor

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven mentioned this pull request Feb 18, 2024
Closed
@prasannavl prasannavl requested a review from Jouzo February 21, 2024 07:55
@sieniven sieniven mentioned this pull request Feb 21, 2024
Merged
9 tasks
Jouzo
Jouzo reviewed Feb 22, 2024
View reviewed changes
lib/ain-evm/src/executor.rs Outdated Show resolved Hide resolved
Jouzo
Jouzo reviewed Feb 22, 2024
View reviewed changes
lib/ain-evm/src/executor.rs Outdated Show resolved Hide resolved
@Bushstar Bushstar merged commit d916737 into master Feb 23, 2024
14 of 16 checks passed
@Bushstar Bushstar deleted the niven/exec-trace-tx branch February 23, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouzo Jouzo Jouzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sieniven @Jouzo @Bushstar