-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure EVM database integrity and consistency with DVM database #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sieniven
changed the title
EVM: Database integrity fixes
EVM: Ensure Database integrity
Jan 17, 2024
sieniven
changed the title
EVM: Ensure Database integrity
EVM: Ensure database integrity
Jan 17, 2024
sieniven
force-pushed
the
niven/db-integrity
branch
from
January 17, 2024 14:52
5bcd8a0
to
e860e3c
Compare
sieniven
changed the title
EVM: Ensure database integrity
Ensure EVM database integrity and consistency with DVM database
Jan 17, 2024
Bushstar
reviewed
Jan 18, 2024
Bushstar
previously approved these changes
Jan 22, 2024
Jouzo
reviewed
Jan 22, 2024
Jouzo
previously approved these changes
Jan 22, 2024
EVM db flush is shifted out of every tip change on the rust side with commit c86861f. Instead, the EVM db flush is now exposed on the FFI, and is called in the same pipeline on the DVM side to keep the DVM and EVM databases consistent in FlushStateToDisk. |
Bushstar
approved these changes
Jan 24, 2024
Jouzo
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues that cause database integrity issues on the EVM side, resulting in a corrupted rocksdb.
Implications
Storage
Consensus