Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix broken win-x64 binary #2766

Merged
merged 4 commits into from
Jan 5, 2024
Merged

CI: Fix broken win-x64 binary #2766

merged 4 commits into from
Jan 5, 2024

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Jan 3, 2024

Summary

  • The PR includes fixes to fix the broken win-x64 binaries built on the multi-arch build CI workflows on build dev, staging and release.
  • The issue is resolved when cross compilation build is on ubuntu 22.04.
  • Temporary workaround to include a new ain-builder specific for windows version while maintaining compatibility for the other target architectures, specifically linux builds due to glibc which is tied to the distro the target binary is being built on.
  • To ensure that releases support Ubuntu versions 20.04 onwards (glibc versions >=2.29 onwards), thus the need to separate the pre-warmed containers.
  • The new ain-win-builder will run on Ubuntu 22.04, while the ain-builder used in all other workflows will maintain compatibility at 20.04.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@Bushstar Bushstar merged commit 02444df into master Jan 5, 2024
15 of 16 checks passed
@Bushstar Bushstar deleted the niven/fix-win64-build branch January 5, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants