icx_makeoffer do not override user set expiry

[Bushstar]

Summary

• icx_makeoffer will always override the user set expiry. There is a check consensus side that the expiry is not less than the default amounts.

ain/src/dfi/consensus/icxorders.cpp

Lines 132 to 137 in 73489ee

	auto expiry = static_cast<int>(height) < consensus.DF10EunosPayaHeight ? CICXMakeOffer::DEFAULT_EXPIRY
	: CICXMakeOffer::EUNOSPAYA_DEFAULT_EXPIRY;
	if (makeoffer.expiry < expiry) {
	return Res::Err("offer expiry must be greater than %d!", expiry - 1);
	}

Implications

• Storage

  • Database reindex required
  • Database reindex optional
  • Database reindex not required
  • None

• Consensus

  • Network upgrade required
  • Includes backward compatible changes
  • Includes consensus workarounds
  • Includes consensus refactors
  • None