Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time, height, consensus to block context #2727

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Conversation

Bushstar
Copy link
Member

Summary

  • Time and height should have been defined in block context instead of transaction context. This PR starts moving them to from transaction context to block context. To keep changes to a minimum this PR adds them to the block context and retains them in transaction context as aliases. This prevents a large changeset in one go which is then safer to implement and easier to review.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl changed the title Add time/height to block context. Alias them in transaction context. Add more items to block context Nov 28, 2023
@prasannavl prasannavl changed the title Add more items to block context Add time, height, consensus to block context Nov 28, 2023
@prasannavl prasannavl merged commit b44fdc6 into master Nov 29, 2023
15 of 16 checks passed
@prasannavl prasannavl deleted the bush/blkctx-timeheight branch November 29, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants