Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add cpp caching and rust cache fixes in CI build workflows #2721

Merged
merged 44 commits into from
Dec 1, 2023

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Nov 26, 2023

Summary

Part 2 of CI improvement, continuation from #2717.

  • Add cpp caching into workflows, caching build depends, defid src build tree and ccache dir.
  • Implementation of ccache into CI build workflows.
  • Dev build workflow will save the cpp caches by default only on every new commit on master. The workflow will also update the stored cpp cache by overwritting existing cpp caches.
  • Fixes to rust build - standardize shared-keys of rust cache to prevent duplicate caches being cached. Rust cache action keys are defaulted to generate with job name if shared-key is not specified - ref: https://github.com/Swatinem/rust-cache/blob/master/src/config.ts#L57-L72
    • Currently, multiple rust caches are being saved
  • Separate rust lint cache from rust build cache
  • Remove rust caching from build release and staging pipelines

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven marked this pull request as ready for review November 27, 2023 01:18
@sieniven sieniven changed the title CI: Add CPP and rust caching into CI workflows CI: Add cpp caching and rust cache fixes in CI build workflows Nov 27, 2023
Jouzo
Jouzo previously approved these changes Nov 28, 2023
@sieniven sieniven requested a review from Jouzo November 29, 2023 06:10
@Bushstar Bushstar merged commit 42d2183 into master Dec 1, 2023
15 of 16 checks passed
@Bushstar Bushstar deleted the niven/ci-add-cache branch December 1, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants