Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: Add single key check for source and destination addresses in transferdomain RPC #2709

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Nov 21, 2023

Summary

  • Add optional parameter for single key check (singlekeycheck) that run on default in transferdomain RPC
  • Single key check pipeline will check that the source and destination addresses specified in the transferdomain RPC matches the same pubkey
  • Guards against unplanned loss in funds to ensure destination address specified in the call is to the correct corresponding address
  • To do a transferdomain to a different destination address that does not correspond to the same key, the RPC will need to explicitly set the singlekeycheck parameter to false
  • Fix all functional tests with the new parameter, and add single key check tests in feature_evm_transferdomain
  • Add legacy addresses into addressmap RPC

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

Bushstar
Bushstar previously approved these changes Nov 21, 2023
@Bushstar Bushstar merged commit 409a891 into master Nov 21, 2023
11 of 13 checks passed
@Bushstar Bushstar deleted the niven/td-single-key-check branch November 21, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants