Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix creating / staging release #2708

Merged
merged 8 commits into from
Nov 23, 2023
Merged

CI: Fix creating / staging release #2708

merged 8 commits into from
Nov 23, 2023

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Nov 20, 2023

Summary

  • This PR contains the more correct fixes in reference to PR CI: Fix Dirty tag to build release workflow #2706
  • Create / staging release workflow waits for multi-arch build jobs and thus the master branch head may have changed during the workflow
  • Or when setting the release, master branch may not be on the commit that the release tag is set on
  • The PR removes explicit checking out of master branch ref in build-release / build-staging pipelines respectively so that we will ensure the correct git commit version in this step
  • Instead when generating build.h file, we will skip git dirty check when the current git commit equals to the reference tag

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit 5a05dd2 into master Nov 23, 2023
19 of 21 checks passed
@prasannavl prasannavl deleted the niven/fix-release branch November 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants