Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant ApplyCustomTx #2689

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Remove redundant ApplyCustomTx #2689

merged 5 commits into from
Jan 5, 2024

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Nov 9, 2023

Summary

  • In the mempool and ConnectBlock pipelines ApplyCustomTx is called as part of the validation. However an additional call to this function is executed via CheckTxInputs. This PR removes that additional call and explicitly gets the information required for the update masternode TX collateral spend check.
  • Change error message output for collateral spend to include expected and found amounts.
  • Update test to correctly check incorrect amount spend.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

sieniven
sieniven previously approved these changes Jan 5, 2024
@Bushstar Bushstar merged commit af30b58 into master Jan 5, 2024
@Bushstar Bushstar deleted the bush/rem-func-txcheck branch January 5, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants