-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD: Move shasum and windows specific in make.sh #2586
Conversation
make.sh
Outdated
|
||
local pkg_path | ||
pkg_path="$(_canonicalize "${build_dir}/${pkg_tar_file_name}")" | ||
if [[ "${TARGET}" == "x86_64-w64-mingw32" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using target here, how about taking a separate "pkg_type" local arg that takes zip or tar with tar as default so it's more generic? Or can just take a use_zip=1/0 as well to simplify.
The type based on target can be set at a higher level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we perhaps use some of the changes and refine them in #2114 into this PR? Just recalled that that PR also cleans up the various CI workflows to implement matrices for our build strategies instead of having multiple repeated code for every supported arch.
That old PR also shifts SHA256 checksum calculation and signing of binaries into make.sh
That PR also contains caching related changes, do we want to include that as well or just the matrix changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing. The merged PR #2717 cleans up these pipelines
Summary
Implications
Storage
Consensus