Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Move shasum and windows specific in make.sh #2586

Closed
wants to merge 5 commits into from

Conversation

WhiteWalker608
Copy link

Summary

  • Added shasum file generation into make.sh
  • Added windows zip package building into make.sh
  • Removed shasum stage from build-release and build-staging pipeline
  • Removed windows zip package building stage from build-release and build-staging pipeline

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

make.sh Outdated

local pkg_path
pkg_path="$(_canonicalize "${build_dir}/${pkg_tar_file_name}")"
if [[ "${TARGET}" == "x86_64-w64-mingw32" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using target here, how about taking a separate "pkg_type" local arg that takes zip or tar with tar as default so it's more generic? Or can just take a use_zip=1/0 as well to simplify.

The type based on target can be set at a higher level

Copy link
Member

@sieniven sieniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we perhaps use some of the changes and refine them in #2114 into this PR? Just recalled that that PR also cleans up the various CI workflows to implement matrices for our build strategies instead of having multiple repeated code for every supported arch.

That old PR also shifts SHA256 checksum calculation and signing of binaries into make.sh

@WhiteWalker608
Copy link
Author

Can we perhaps use some of the changes and refine them in #2114 into this PR? Just recalled that that PR also cleans up the various CI workflows to implement matrices for our build strategies instead of having multiple repeated code for every supported arch.

That old PR also shifts SHA256 checksum calculation and signing of binaries into make.sh

That PR also contains caching related changes, do we want to include that as well or just the matrix changes

@sieniven sieniven closed this Dec 7, 2023
@sieniven sieniven deleted the ci/shasum-packaging branch December 7, 2023 07:54
Copy link
Member

@sieniven sieniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing. The merged PR #2717 cleans up these pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants