Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Shift prepay fee calculation into execution, fix failed transactions pipeline #2531

Merged
merged 2 commits into from
Oct 4, 2023
Merged

EVM: Shift prepay fee calculation into execution, fix failed transactions pipeline #2531

merged 2 commits into from
Oct 4, 2023

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Oct 4, 2023 •
edited
Loading

Summary

  • More correct execution of EVM txs, fixes validate_evm_txs from passing max prepay gas fees into execution.
  • Once an EVM tx fails, subsequent evm txs may fail as ordering is no longer ensured. We will queue all subsequent failed txs and remove them from the DVM block.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven changed the title EVM: Shift prepay fee calculation into execution EVM: Shift prepay fee calculation into execution, fix failed transactions pipeline Oct 4, 2023
@Bushstar Bushstar merged commit dd2ece4 into master Oct 4, 2023
@Bushstar Bushstar deleted the evm/fix-prepay-fees branch October 4, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bushstar Bushstar Bushstar approved these changes

@prasannavl prasannavl Awaiting requested review from prasannavl

@Jouzo Jouzo Awaiting requested review from Jouzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sieniven @Bushstar