Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM Transaction queue revamp #2416

Merged
merged 71 commits into from
Sep 12, 2023
Merged

EVM Transaction queue revamp #2416

merged 71 commits into from
Sep 12, 2023

Conversation

Jouzo
Copy link
Collaborator

@Jouzo Jouzo commented Sep 5, 2023 •
edited
Loading

Summary

  • Add additional state_root to queued tx representing its resulting changes to the state trie
  • Fix dangling queue memory leak

Implications

  • Storage

    • Database reindex required

  • Consensus

    • Network upgrade required

@prasannavl prasannavl added the v/next-release Items ready or targeted for upcoming release(s) label Sep 6, 2023
@Jouzo Jouzo force-pushed the evm_queue_state_root_tracking branch from 9adea5f to a9a7ac1 Compare September 6, 2023 22:21
@Jouzo Jouzo changed the title Keep track of state changes in tx queue EVM Transaction queue revamp Sep 7, 2023
Jouzo and others added 24 commits September 8, 2023 15:01
@Jouzo
TD check fixes
a4b3caf
@Jouzo
Try to remove existing queue
47e75fc
@Jouzo
Support multiple TD per block
858f785
@Jouzo
Pass corect evmQueueId for removal
0f61beb
@Bushstar
Delete queue on error only
c19e313
@Bushstar
Remove logging
7154608
@Bushstar
Pass 0 evmQueueId
7250594
@Bushstar
Reject new entry with the same fee as existing entry
4c6e7b0
@Bushstar
Add current TX into rebuild account view
8c8f36a
@Bushstar
Add lower nonce to results
96befd2
@Bushstar
Handle and define lower_nonce for transferdomain TXs
be85ab8
@Bushstar
Prevalidate to allow higher nonces into mempool
25d96da
@Jouzo
Fix evm_try_get_tx_sender_info_from_raw_tx return
48799a7
@Bushstar
Remove replaced TX from mempool
3fb6954
@Jouzo
Remove genesis dangling queue
1f6cea1
@Jouzo
Fix prevalidate call block number
9f8f38e
@Jouzo
Downgrade deployment log level
6727dfb
@Jouzo
Merge branch master into evm_queue_state_root_tracking
7fb2379
@Bushstar
Merge branch 'master' into evm_queue_state_root_tracking
4fdc6f2
@Bushstar
Delete map entries after usage
7cd1c07
@Bushstar
Rebuild mempool on reorg
330e14b
@Bushstar
Wipe queue ID on clearmempool
307c553
@Jouzo
Remove testing of wrong behaviour
c075a0b
@Jouzo
Fix test for new mempool behaviour
3639e09
@prasannavl prasannavl marked this pull request as ready for review September 12, 2023 03:25
@Bushstar Bushstar merged commit 638d314 into master Sep 12, 2023
@Bushstar Bushstar deleted the evm_queue_state_root_tracking branch September 12, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jouzo @prasannavl @Bushstar