Fork out NotAllowedToFail #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvbfan
requested review from
uzyn,
monstrobishi,
Bushstar and
ShengguangXiao
bvbfan
force-pushed
the
fix/fork_notallowedtofail
branch
from
8157e9d to
9864e32
Compare
bvbfan
force-pushed
the
fix/fork_notallowedtofail
branch
from
9864e32 to
3bf8573
Compare
|
It's 1.5.x now. |
uzyn
reviewed
Feb 17, 2021
src/chainparams.cpp
Outdated
| consensus.mn.anchoringLag = 15; | ||
|
|
||
| consensus.mn.anchoringTimeDepth = 3 * 60 * 60; // 3 hours | ||
| consensus.mn.anchoringTeamChange = 120; // Number of blocks |
There was a problem hiding this comment.
Is this intended to be in this PR?
|
@uzyn because the base is currently set to master, it should be 1.5.x |
bvbfan
force-pushed
the
fix/fork_notallowedtofail
branch
from
3bf8573 to
b521261
Compare
Signed-off-by: Anthony Fieroni <[email protected]>
bvbfan
force-pushed
the
fix/fork_notallowedtofail
branch
from
b521261 to
184e8c7
Compare
monstrobishi
approved these changes
Feb 17, 2021
Bushstar
pushed a commit
that referenced
this pull request
Feb 17, 2021
Signed-off-by: Anthony Fieroni <[email protected]>
monstrobishi
added a commit
that referenced
this pull request
Feb 17, 2021
* Dakota fork logic * SPV logging category * Add Dakota to getblockchaininfo * Make update token only need owner auth * Open createpoorpair after dakota fork and add unittest * Fix unittest fail * Address review comments * Fix unittest fail * Fix swap max price calculation Signed-off-by: Anthony Fieroni <[email protected]> * Reduce collateral amount for masternode creation Signed-off-by: Anthony Fieroni <[email protected]> * Unit tests masternode collateral amount creation Signed-off-by: Anthony Fieroni <[email protected]> * Revert "Make update token only need owner auth" * Anchor refactor * Reverse community balance on reorg * Minor changes and corrections Regtest use mainnet params. Always apply quorum check on anchors read from Bitcoin, invalidates all current anchors. Do not show old anchors in listanchors. Use correct iterator in loop. Post-AMK logic always true in CreateNewBlock payment code. spv_createanchor requires SPV to fully validate anchor auths. Set realistic times in fake SPV Bitcoin TXs. Update C++ anchor unit tests. * Log genesis block errors. Useful for debugging unexpected cases. * Anchor functional test updates for Dakota * Fork out NotAllowedToFail (#223) Signed-off-by: Anthony Fieroni <[email protected]> * Set Dakota fork heights * Update chainparams.cpp Co-authored-by: Peter Bushnell <[email protected]> Co-authored-by: ShengguangXiao <[email protected]> Co-authored-by: Anthony Fieroni <[email protected]>
ShengguangXiao
pushed a commit
that referenced
this pull request
Mar 15, 2021
partially implement setrawprice Signed-off-by: DeFiDev <[email protected]> refactor oracles Signed-off-by: DeFiDev <[email protected]> refactore according to changed design Signed-off-by: DeFiDev <[email protected]> refactor oracles, implement oraclesview, partially implement setoracledata Signed-off-by: DeFiDev <[email protected]> partially fix setoracledata method Signed-off-by: DeFiDev <[email protected]> get rid of timestamp type Signed-off-by: DeFiDev <[email protected]> fix style issue Signed-off-by: DeFiDev <[email protected]> debug setoracledata, fix errors Signed-off-by: DeFiDev <[email protected]> remove HasOracleAuth impl refactor oracle view, add appointoracle Signed-off-by: DeFiDev <[email protected]> correct parse address Signed-off-by: DeFiDev <[email protected]> implementing rpc methods Signed-off-by: DeFiDev <[email protected]> debugging feature oracles Signed-off-by: DeFiDev <[email protected]> set correct oracle address Signed-off-by: DeFiDev <[email protected]> debugging oracles in progress Signed-off-by: DeFiDev <[email protected]> debugging in process Signed-off-by: DeFiDev <[email protected]> debugging in process Signed-off-by: DeFiDev <[email protected]> fix few errors, debugging almost completed Signed-off-by: DeFiDev <[email protected]> added update oracle method, refactored code Signed-off-by: DeFiDev <[email protected]> implemented listlatestprices Signed-off-by: DeFiDev <[email protected]> add getprice Signed-off-by: DeFiDev <[email protected]> refactor listlatestrawprices Signed-off-by: DeFiDev <[email protected]> refactoring oracles to use different currencies. in process, isn't compilable yet Signed-off-by: DeFiDev <[email protected]> make oracles use currencies Signed-off-by: DeFiDev <[email protected]> refactor, make proper auth, small fixes Signed-off-by: DeFiDev <[email protected]> fix iteration error Signed-off-by: DeFiDev <[email protected]> fix error in logic Signed-off-by: DeFiDev <[email protected]> implement listprices Signed-off-by: DeFiDev <[email protected]> refactor Signed-off-by: DeFiDev <[email protected]> refactor allowed pairs parameter for appointoracle and updateoracle Signed-off-by: DeFiDev <[email protected]> add txs parameters check before sending, debugging updateoracle, removeoracle, setoracledata Signed-off-by: DeFiDev <[email protected]> debug updateoracle & removeoracle Signed-off-by: DeFiDev <[email protected]> added getpricefeeds rpc method Signed-off-by: DeFiDev <[email protected]> fixed getpricefeeds Signed-off-by: DeFiDev <[email protected]> fix problem with transactions, remove debug code Signed-off-by: DeFiDev <[email protected]> add tokens formatting Signed-off-by: DeFiDev <[email protected]> implementing tests in progress Signed-off-by: DeFiDev <[email protected]> fix mistakes Signed-off-by: DeFiDev <[email protected]> implement most test cases Signed-off-by: DeFiDev <[email protected]> implement more test cases, make workaround for error code 0 Signed-off-by: DeFiDev <[email protected]> correct updateoracle to preserve existing prices Signed-off-by: DeFiDev <[email protected]> fix tests after correcting updateoracle, add check for expiration Signed-off-by: DeFiDev <[email protected]> Fix sendtokentoaddress account selection mode Signed-off-by: Anthony Fieroni <[email protected]> Return operator != in auto select balances Signed-off-by: Anthony Fieroni <[email protected]> Fix potential node syncing issues on Travis Signed-off-by: Anthony Fieroni <[email protected]> Add ability for multiple operators per node Signed-off-by: Anthony Fieroni <[email protected]> Fix test runner Signed-off-by: Anthony Fieroni <[email protected]> Prevent sending DFI tokens to non-self addresses by default Signed-off-by: Anthony Fieroni <[email protected]> Update cache of owned addresses Signed-off-by: Anthony Fieroni <[email protected]> Fix gettokenbalances Signed-off-by: Anthony Fieroni <[email protected]> Fix metadata in poolswap rpc call Signed-off-by: Anthony Fieroni <[email protected]> Add checkpoint data Minimize custom tx logs Signed-off-by: Anthony Fieroni <[email protected]> Show log on new tip every 20 seconds Signed-off-by: Anthony Fieroni <[email protected]> Remove duplicate anchor reward log Signed-off-by: Anthony Fieroni <[email protected]> Increase file chunk size Signed-off-by: Anthony Fieroni <[email protected]> Include watch addresses to acindex-mineonly Signed-off-by: Anthony Fieroni <[email protected]> Search in for watch addresses always in mine table as well as in wallet Signed-off-by: Anthony Fieroni <[email protected]> Try blocking only dfi token Std pair Remove unused variable Fix unit test Fix unit test Fix unit test Add custom_tx option in listtransaction rpc Change option to exlude custom transactions Set default value of exclude_custom_tx to false, add unittest Fix lint error Show address instead of script as pool owner Signed-off-by: Anthony Fieroni <[email protected]> Fix auto select accounts Signed-off-by: Anthony Fieroni <[email protected]> Added checkpoint Add AutoAuthPrep meta data to auto auth TXs Invalidate last checkpoint block to reconsider invalid blocks Signed-off-by: Anthony Fieroni <[email protected]> Strip out spam syncing block header messages Signed-off-by: Anthony Fieroni <[email protected]> Add explicit check for invalid blocks Signed-off-by: Anthony Fieroni <[email protected]> Update validation.cpp Some small tidyup Added stale bot Added stale bot Prevent downgrade to genesis block on wrong chain Signed-off-by: Anthony Fieroni <[email protected]> Do not read stream out of its bounds in FindByte Signed-off-by: Anthony Fieroni <[email protected]> Do not search in wallet for custom tx type Signed-off-by: Anthony Fieroni <[email protected]> Check for watch address change Signed-off-by: Anthony Fieroni <[email protected]> Don't call lsn_reset in periodic flush Signed-off-by: Anthony Fieroni <[email protected]> Make wallet more reponsive and less buggy Signed-off-by: Anthony Fieroni <[email protected]> Added stale bot Added stale bot Prevent downgrade to genesis block on wrong chain Signed-off-by: Anthony Fieroni <[email protected]> Limit size of wallet tx. Strip out dead wallet code Signed-off-by: Anthony Fieroni <[email protected]> Fix operator lower precedence warning Signed-off-by: Anthony Fieroni <[email protected]> Add lock free guard mechanism Signed-off-by: Anthony Fieroni <[email protected]> Use cached version of wallet filter type. Strip out more dead code Signed-off-by: Anthony Fieroni <[email protected]> Do not read stream out of its bounds in FindByte Signed-off-by: Anthony Fieroni <[email protected]> Fix wallet watch only address visibility Signed-off-by: Anthony Fieroni <[email protected]> Yield a slot to other staker threads Signed-off-by: Anthony Fieroni <[email protected]> Pin github-actions to a full length commit SHA (#226) 1.5.x (#227) * Dakota fork logic * SPV logging category * Add Dakota to getblockchaininfo * Make update token only need owner auth * Open createpoorpair after dakota fork and add unittest * Fix unittest fail * Address review comments * Fix unittest fail * Fix swap max price calculation Signed-off-by: Anthony Fieroni <[email protected]> * Reduce collateral amount for masternode creation Signed-off-by: Anthony Fieroni <[email protected]> * Unit tests masternode collateral amount creation Signed-off-by: Anthony Fieroni <[email protected]> * Revert "Make update token only need owner auth" * Anchor refactor * Reverse community balance on reorg * Minor changes and corrections Regtest use mainnet params. Always apply quorum check on anchors read from Bitcoin, invalidates all current anchors. Do not show old anchors in listanchors. Use correct iterator in loop. Post-AMK logic always true in CreateNewBlock payment code. spv_createanchor requires SPV to fully validate anchor auths. Set realistic times in fake SPV Bitcoin TXs. Update C++ anchor unit tests. * Log genesis block errors. Useful for debugging unexpected cases. * Anchor functional test updates for Dakota * Fork out NotAllowedToFail (#223) Signed-off-by: Anthony Fieroni <[email protected]> * Set Dakota fork heights * Update chainparams.cpp Co-authored-by: Peter Bushnell <[email protected]> Co-authored-by: ShengguangXiao <[email protected]> Co-authored-by: Anthony Fieroni <[email protected]> Adding variable for make args, ignore .vscode dir (#228) Do not throw in case of account error at rewards redistribution (#230) * Do not throw in case of account error at rewards redistribution Signed-off-by: Anthony Fieroni <[email protected]> * Sync nodes after reset balance in wallet avoid reuse test Signed-off-by: Anthony Fieroni <[email protected]> * Fix nodes out of sync in custom rewards test Signed-off-by: Anthony Fieroni <[email protected]> Moved security policy from issue into repo. (#237) * Moved security policy from issue into repo. (GitHub recommended) * Changed 20,000 DFI to 50,000 USD worth of DFI Branding consistency for README.md (#243) DeFi Blockchain to DeFiChain License update (#245) Co-authored-by: Ahmed Hilali <[email protected]> Setup CODEOWNERS (#242) Co-authored-by: Ahmed Hilali <[email protected]> OSS Governance Bot setup for PR & Issue (#241) Labels syncing automation (#240) Automated release drafting (#239) Setup issue template for governance agility (#238) Remove storing pre-fork anchor reward (#235) Co-authored-by: Ahmed Hilali <[email protected]> Add ability to interrupt long-standing revert to previous checkpoint (#233) * Respect shutdown request at block disconnect to previous checkpoint Signed-off-by: Anthony Fieroni <[email protected]> * Add new checkpoints Co-authored-by: Ahmed Hilali <[email protected]> Reject protocol versions less than 70016 (#236) * Reject protocol versions less than 70016 * Increment version in tests Co-authored-by: Ahmed Hilali <[email protected]> Improve anchor API help message (#246) Co-authored-by: Ahmed Hilali <[email protected]> Refactor mn_rpc file and split into different categories based on RPC types (#234) * Initial rpc refactor to categories files * Clean up * Added include guard and ran clang-format * Adding new lines to file end * Fix lint error * Adding missing masternodes/mn_rpc.h to Makefile.am * Register rpc commands in its own files * Add new rpc files to check-rpc-mappings.py Co-authored-by: Ahmed Hilali <[email protected]> All anchors and validation moved to pending (#249) Reject paid confirmations. Only vote if not in IBD. (#253) Restore handling of equal work in block when invalidating blocks (#229) Co-authored-by: Ahmed Hilali <[email protected]> Update setup-masternodes.md (#247) SPV: hard code required spv solution to related network. (#248) Co-authored-by: Ahmed Hilali <[email protected]> Wipe confs and revote after new team. New getactivemasternodes call. (#254) Flush when it's needed in reindex chainstate (#255) Signed-off-by: Anthony Fieroni <[email protected]> Wait wallet unlock to stake (#256) Signed-off-by: Anthony Fieroni <[email protected]> fix merge issues Signed-off-by: DeFiDev <[email protected]> replaced getpricefeeds with getoracledata, refactor tests Signed-off-by: DeFiDev <[email protected]> Fix oracle rpc api bugs (#276) * Fix oracle rpc api bugs * fix remaining issues Signed-off-by: DeFiDev <[email protected]> Co-authored-by: DeFiDev <[email protected]>
ShengguangXiao
pushed a commit
that referenced
this pull request
Mar 15, 2021
partially implement setrawprice Signed-off-by: DeFiDev <[email protected]> refactor oracles Signed-off-by: DeFiDev <[email protected]> refactore according to changed design Signed-off-by: DeFiDev <[email protected]> refactor oracles, implement oraclesview, partially implement setoracledata Signed-off-by: DeFiDev <[email protected]> partially fix setoracledata method Signed-off-by: DeFiDev <[email protected]> get rid of timestamp type Signed-off-by: DeFiDev <[email protected]> fix style issue Signed-off-by: DeFiDev <[email protected]> debug setoracledata, fix errors Signed-off-by: DeFiDev <[email protected]> remove HasOracleAuth impl refactor oracle view, add appointoracle Signed-off-by: DeFiDev <[email protected]> correct parse address Signed-off-by: DeFiDev <[email protected]> implementing rpc methods Signed-off-by: DeFiDev <[email protected]> debugging feature oracles Signed-off-by: DeFiDev <[email protected]> set correct oracle address Signed-off-by: DeFiDev <[email protected]> debugging oracles in progress Signed-off-by: DeFiDev <[email protected]> debugging in process Signed-off-by: DeFiDev <[email protected]> debugging in process Signed-off-by: DeFiDev <[email protected]> fix few errors, debugging almost completed Signed-off-by: DeFiDev <[email protected]> added update oracle method, refactored code Signed-off-by: DeFiDev <[email protected]> implemented listlatestprices Signed-off-by: DeFiDev <[email protected]> add getprice Signed-off-by: DeFiDev <[email protected]> refactor listlatestrawprices Signed-off-by: DeFiDev <[email protected]> refactoring oracles to use different currencies. in process, isn't compilable yet Signed-off-by: DeFiDev <[email protected]> make oracles use currencies Signed-off-by: DeFiDev <[email protected]> refactor, make proper auth, small fixes Signed-off-by: DeFiDev <[email protected]> fix iteration error Signed-off-by: DeFiDev <[email protected]> fix error in logic Signed-off-by: DeFiDev <[email protected]> implement listprices Signed-off-by: DeFiDev <[email protected]> refactor Signed-off-by: DeFiDev <[email protected]> refactor allowed pairs parameter for appointoracle and updateoracle Signed-off-by: DeFiDev <[email protected]> add txs parameters check before sending, debugging updateoracle, removeoracle, setoracledata Signed-off-by: DeFiDev <[email protected]> debug updateoracle & removeoracle Signed-off-by: DeFiDev <[email protected]> added getpricefeeds rpc method Signed-off-by: DeFiDev <[email protected]> fixed getpricefeeds Signed-off-by: DeFiDev <[email protected]> fix problem with transactions, remove debug code Signed-off-by: DeFiDev <[email protected]> add tokens formatting Signed-off-by: DeFiDev <[email protected]> implementing tests in progress Signed-off-by: DeFiDev <[email protected]> fix mistakes Signed-off-by: DeFiDev <[email protected]> implement most test cases Signed-off-by: DeFiDev <[email protected]> implement more test cases, make workaround for error code 0 Signed-off-by: DeFiDev <[email protected]> correct updateoracle to preserve existing prices Signed-off-by: DeFiDev <[email protected]> fix tests after correcting updateoracle, add check for expiration Signed-off-by: DeFiDev <[email protected]> Fix sendtokentoaddress account selection mode Signed-off-by: Anthony Fieroni <[email protected]> Return operator != in auto select balances Signed-off-by: Anthony Fieroni <[email protected]> Fix potential node syncing issues on Travis Signed-off-by: Anthony Fieroni <[email protected]> Add ability for multiple operators per node Signed-off-by: Anthony Fieroni <[email protected]> Fix test runner Signed-off-by: Anthony Fieroni <[email protected]> Prevent sending DFI tokens to non-self addresses by default Signed-off-by: Anthony Fieroni <[email protected]> Update cache of owned addresses Signed-off-by: Anthony Fieroni <[email protected]> Fix gettokenbalances Signed-off-by: Anthony Fieroni <[email protected]> Fix metadata in poolswap rpc call Signed-off-by: Anthony Fieroni <[email protected]> Add checkpoint data Minimize custom tx logs Signed-off-by: Anthony Fieroni <[email protected]> Show log on new tip every 20 seconds Signed-off-by: Anthony Fieroni <[email protected]> Remove duplicate anchor reward log Signed-off-by: Anthony Fieroni <[email protected]> Increase file chunk size Signed-off-by: Anthony Fieroni <[email protected]> Include watch addresses to acindex-mineonly Signed-off-by: Anthony Fieroni <[email protected]> Search in for watch addresses always in mine table as well as in wallet Signed-off-by: Anthony Fieroni <[email protected]> Try blocking only dfi token Std pair Remove unused variable Fix unit test Fix unit test Fix unit test Add custom_tx option in listtransaction rpc Change option to exlude custom transactions Set default value of exclude_custom_tx to false, add unittest Fix lint error Show address instead of script as pool owner Signed-off-by: Anthony Fieroni <[email protected]> Fix auto select accounts Signed-off-by: Anthony Fieroni <[email protected]> Added checkpoint Add AutoAuthPrep meta data to auto auth TXs Invalidate last checkpoint block to reconsider invalid blocks Signed-off-by: Anthony Fieroni <[email protected]> Strip out spam syncing block header messages Signed-off-by: Anthony Fieroni <[email protected]> Add explicit check for invalid blocks Signed-off-by: Anthony Fieroni <[email protected]> Update validation.cpp Some small tidyup Added stale bot Added stale bot Prevent downgrade to genesis block on wrong chain Signed-off-by: Anthony Fieroni <[email protected]> Do not read stream out of its bounds in FindByte Signed-off-by: Anthony Fieroni <[email protected]> Do not search in wallet for custom tx type Signed-off-by: Anthony Fieroni <[email protected]> Check for watch address change Signed-off-by: Anthony Fieroni <[email protected]> Don't call lsn_reset in periodic flush Signed-off-by: Anthony Fieroni <[email protected]> Make wallet more reponsive and less buggy Signed-off-by: Anthony Fieroni <[email protected]> Added stale bot Added stale bot Prevent downgrade to genesis block on wrong chain Signed-off-by: Anthony Fieroni <[email protected]> Limit size of wallet tx. Strip out dead wallet code Signed-off-by: Anthony Fieroni <[email protected]> Fix operator lower precedence warning Signed-off-by: Anthony Fieroni <[email protected]> Add lock free guard mechanism Signed-off-by: Anthony Fieroni <[email protected]> Use cached version of wallet filter type. Strip out more dead code Signed-off-by: Anthony Fieroni <[email protected]> Do not read stream out of its bounds in FindByte Signed-off-by: Anthony Fieroni <[email protected]> Fix wallet watch only address visibility Signed-off-by: Anthony Fieroni <[email protected]> Yield a slot to other staker threads Signed-off-by: Anthony Fieroni <[email protected]> Pin github-actions to a full length commit SHA (#226) 1.5.x (#227) * Dakota fork logic * SPV logging category * Add Dakota to getblockchaininfo * Make update token only need owner auth * Open createpoorpair after dakota fork and add unittest * Fix unittest fail * Address review comments * Fix unittest fail * Fix swap max price calculation Signed-off-by: Anthony Fieroni <[email protected]> * Reduce collateral amount for masternode creation Signed-off-by: Anthony Fieroni <[email protected]> * Unit tests masternode collateral amount creation Signed-off-by: Anthony Fieroni <[email protected]> * Revert "Make update token only need owner auth" * Anchor refactor * Reverse community balance on reorg * Minor changes and corrections Regtest use mainnet params. Always apply quorum check on anchors read from Bitcoin, invalidates all current anchors. Do not show old anchors in listanchors. Use correct iterator in loop. Post-AMK logic always true in CreateNewBlock payment code. spv_createanchor requires SPV to fully validate anchor auths. Set realistic times in fake SPV Bitcoin TXs. Update C++ anchor unit tests. * Log genesis block errors. Useful for debugging unexpected cases. * Anchor functional test updates for Dakota * Fork out NotAllowedToFail (#223) Signed-off-by: Anthony Fieroni <[email protected]> * Set Dakota fork heights * Update chainparams.cpp Co-authored-by: Peter Bushnell <[email protected]> Co-authored-by: ShengguangXiao <[email protected]> Co-authored-by: Anthony Fieroni <[email protected]> Adding variable for make args, ignore .vscode dir (#228) Do not throw in case of account error at rewards redistribution (#230) * Do not throw in case of account error at rewards redistribution Signed-off-by: Anthony Fieroni <[email protected]> * Sync nodes after reset balance in wallet avoid reuse test Signed-off-by: Anthony Fieroni <[email protected]> * Fix nodes out of sync in custom rewards test Signed-off-by: Anthony Fieroni <[email protected]> Moved security policy from issue into repo. (#237) * Moved security policy from issue into repo. (GitHub recommended) * Changed 20,000 DFI to 50,000 USD worth of DFI Branding consistency for README.md (#243) DeFi Blockchain to DeFiChain License update (#245) Co-authored-by: Ahmed Hilali <[email protected]> Setup CODEOWNERS (#242) Co-authored-by: Ahmed Hilali <[email protected]> OSS Governance Bot setup for PR & Issue (#241) Labels syncing automation (#240) Automated release drafting (#239) Setup issue template for governance agility (#238) Remove storing pre-fork anchor reward (#235) Co-authored-by: Ahmed Hilali <[email protected]> Add ability to interrupt long-standing revert to previous checkpoint (#233) * Respect shutdown request at block disconnect to previous checkpoint Signed-off-by: Anthony Fieroni <[email protected]> * Add new checkpoints Co-authored-by: Ahmed Hilali <[email protected]> Reject protocol versions less than 70016 (#236) * Reject protocol versions less than 70016 * Increment version in tests Co-authored-by: Ahmed Hilali <[email protected]> Improve anchor API help message (#246) Co-authored-by: Ahmed Hilali <[email protected]> Refactor mn_rpc file and split into different categories based on RPC types (#234) * Initial rpc refactor to categories files * Clean up * Added include guard and ran clang-format * Adding new lines to file end * Fix lint error * Adding missing masternodes/mn_rpc.h to Makefile.am * Register rpc commands in its own files * Add new rpc files to check-rpc-mappings.py Co-authored-by: Ahmed Hilali <[email protected]> All anchors and validation moved to pending (#249) Reject paid confirmations. Only vote if not in IBD. (#253) Restore handling of equal work in block when invalidating blocks (#229) Co-authored-by: Ahmed Hilali <[email protected]> Update setup-masternodes.md (#247) SPV: hard code required spv solution to related network. (#248) Co-authored-by: Ahmed Hilali <[email protected]> Wipe confs and revote after new team. New getactivemasternodes call. (#254) Flush when it's needed in reindex chainstate (#255) Signed-off-by: Anthony Fieroni <[email protected]> Wait wallet unlock to stake (#256) Signed-off-by: Anthony Fieroni <[email protected]> fix merge issues Signed-off-by: DeFiDev <[email protected]> replaced getpricefeeds with getoracledata, refactor tests Signed-off-by: DeFiDev <[email protected]> Fix oracle rpc api bugs (#276) * Fix oracle rpc api bugs * fix remaining issues Signed-off-by: DeFiDev <[email protected]> Co-authored-by: DeFiDev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct PR for
NotAllowedToFailplan for 1.5.x hardfork.