Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evm tx hash and add test case #2078

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Fix evm tx hash and add test case #2078

merged 2 commits into from
Jun 16, 2023

Conversation

DocteurPing
Copy link

Summary

  • Fix for the vmmap function. The SHA3 function was giving a reverse hash of the transaction. also added a test to check that it's working.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@DocteurPing DocteurPing requested a review from Bushstar June 16, 2023 08:18
@Bushstar Bushstar merged commit 3a6d85a into master Jun 16, 2023
@Bushstar Bushstar deleted the fix/vmmap branch June 16, 2023 09:21
canonbrother pushed a commit that referenced this pull request Jun 19, 2023
@canonbrother
Fix evm tx hash and add test case (#2078)
53fb97f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bushstar Bushstar Awaiting requested review from Bushstar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DocteurPing @Bushstar