Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross platform builds and additional refinements #2044

Merged
merged 22 commits into from
Jun 12, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Jun 11, 2023

Summary

  • Propagate C/CXXFLAGS properly for darwin builds.
  • Add the win32 libs for additional dependencies taken on by Rust projects for mingw builds.
  • Switch make.sh locale to en_US.UTF-8 from POSIX to workaround Apple systems.
  • Modify linter to allow en_US.UTF-8 for shell scripts
  • Remove forcing --platform on docker noarch.dockerfile workflow
  • Enable cctools support for both aarch64 and x64 to build natively on both build hosts.
  • Cleanup of misc experiments that's not meant for master.

Context

  • Bitcoin depends overrides C/CXX instead of C/CXXFLAGS to override cross compilers for darwin.
  • This results in incorrect propagation, as well inconsistent behaviors of overriding
    flags during boost builds.

Workaround

  • For now, we keep the override the same, as there are other blockers to clean this up.
  • However, we also pass down the same to C/CXXFLAGS correctly so it matches and propagates cleanly
    to the rest of the build.
  • Remove boost overrides that'll end up failing building boost, since this also overrides sysroot,
    resulting in not finding the correct includes.

@prasannavl prasannavl changed the title Fix for darwin cross-compiles, cleanup. Fix for darwin, mingw cross-compiles, cleanup. Jun 11, 2023
@prasannavl prasannavl changed the title Fix for darwin, mingw cross-compiles, cleanup. Fix cross platform builds and additional refinements Jun 11, 2023
@sieniven sieniven requested review from Bushstar and Jouzo as code owners June 12, 2023 07:29
@prasannavl prasannavl merged commit 3708c2d into master Jun 12, 2023
@prasannavl prasannavl deleted the pvl/ci-darwin-fix-and-cleanup branch June 12, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants