Remove Require from governance attributes
#1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jouzo
previously approved these changes
Mar 14, 2023
DocteurPing
reviewed
Mar 15, 2023
|
Logic LGTM. Let's fix @DocteurPing's catch and go ahead. |
prasannavl
changed the title
Require from governance attributes
prasannavl
added
the
v/next-release
Mixa84
pushed a commit
to Mixa84/ain
that referenced
this pull request
Mar 17, 2023
* Remove require from ATTRIBUTES * Fix format of errors for strings --------- Co-authored-by: cedric ogire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve performance
Requirelogic was removed from some of the hotpaths earlier and also converted to lambas for lazy evaluation of the error code path.However this has defeated the rationale for introduction in the first place making it verbose and noisy. So, to keep with one convention through the code base, this PR continues the removal of Require.
Area: Gov Var Attributes