Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch assert to propogating error so it doesn't crash on corrupt data #1809

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

prasannavl
Copy link
Member

/kind fix

  • If the snapshot or node isn't shutdown, it gets caught on an assert instead of a graceful error. This is undesirable for multiple reasons, that logs are incomplete, crashes are often not noticed on stdouts, etc.
  • This removes the assert and turns it into an error that's caught by the main thread and shutdown

@prasannavl prasannavl added the v/next-release Items ready or targeted for upcoming release(s) label Mar 9, 2023
@prasannavl prasannavl merged commit c8f5616 into master Mar 9, 2023
@prasannavl prasannavl deleted the pvl/corrupt-data-error branch March 9, 2023 02:56
@dcorral dcorral mentioned this pull request Mar 17, 2023
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants