Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getburninfo memoization #1796

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Fix getburninfo memoization #1796

merged 4 commits into from
Mar 6, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Mar 3, 2023 •
edited
Loading

/kind fix

  • Fix getburninfo consortium tokens by adjusting the memoization result
  • Use correct behavior of shared pointers (Fix getburninfo by removing consortium tokens #1794 behaviour appears to work due to copying of the values including recreating the internal maps again, but uses shared pointers incorrectly.

Note: This also expects other later PRs:

@prasannavl prasannavl mentioned this pull request Mar 3, 2023
Closed
@prasannavl prasannavl changed the title Fix getburninfo Fix getburninfo memoization Mar 6, 2023
@prasannavl prasannavl mentioned this pull request Mar 6, 2023
Merged
@Bushstar Bushstar enabled auto-merge March 6, 2023 04:23
@Bushstar Bushstar added this pull request to the merge queue Mar 6, 2023
@Bushstar Bushstar removed this pull request from the merge queue due to a manual request Mar 6, 2023
@Bushstar Bushstar merged commit e181307 into master Mar 6, 2023
@Bushstar Bushstar deleted the pvl/fix-get-burninfo branch March 6, 2023 04:26
@dcorral dcorral mentioned this pull request Mar 7, 2023
Merged
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouzo Jouzo Jouzo left review comments

@Bushstar Bushstar Bushstar approved these changes

Assignees

@prasannavl prasannavl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prasannavl @Bushstar @Jouzo @defichain-bot