Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of ForEachAccount #1765

Merged
merged 8 commits into from
Feb 20, 2023
Merged

Remove usage of ForEachAccount #1765

merged 8 commits into from
Feb 20, 2023

Conversation

shohamc1
Copy link
Contributor

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

Masternode operator addresses receiving voting rewards do not show up on gettokenbalances. This PR fixes the issue so that voting rewards show up in gettokenbalances.

Which issue(s) does this PR fixes?:

Fixes #1763

@shohamc1 shohamc1 changed the title Fix missing balances in gettokenbalances rpc: Fix missing balances in gettokenbalances Feb 16, 2023
Bushstar
Bushstar previously approved these changes Feb 16, 2023
@Bushstar Bushstar changed the title rpc: Fix missing balances in gettokenbalances Remove usage of ForEachAccount Feb 17, 2023
@prasannavl prasannavl merged commit 912aea0 into master Feb 20, 2023
@prasannavl prasannavl deleted the fix-gettokenbalances branch February 20, 2023 04:31
@prasannavl
Copy link
Member

prasannavl commented Feb 23, 2023

TODO: Basic perf observation metrics. cc/ @shohamc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCG Voting rewards are not spendable
4 participants