Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor -txordering to remove multiple GetArg calls #1761

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Refactor -txordering to remove multiple GetArg calls #1761

merged 5 commits into from
Feb 16, 2023

Conversation

shohamc1
Copy link
Contributor

What kind of PR is this?:

/kind refactor

What this PR does / why we need it:

@prasannavl prasannavl self-requested a review February 15, 2023 07:56
prasannavl
prasannavl approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@prasannavl prasannavl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

  • Deprecates blocktimeordering
  • Hands off internal impl of blocktimeordering to txordering - and make things cleaner.

@prasannavl prasannavl requested a review from Bushstar February 15, 2023 07:57
@prasannavl
Copy link
Member

Jellyfish still on failures due to Ubuntu 18 deprecation. Ignoring and merging.

@prasannavl prasannavl merged commit 380dceb into master Feb 16, 2023
@prasannavl prasannavl deleted the refactor-txordering branch February 16, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl prasannavl approved these changes

@Bushstar Bushstar Awaiting requested review from Bushstar

Assignees

@shohamc1 shohamc1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shohamc1 @prasannavl @defichain-bot