Fix start pagination for listgovproposals #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixa84
requested review from
wafflespeanut,
prasannavl and
Jouzo
as code owners
fuxingloh
pushed a commit
to BirthdayResearch/jellyfishsdk
that referenced
this pull request
Jan 12, 2023
…and pagination (#1954) <!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: - To update `listGovProposals` to accept `cycle` and `pagination` added in DeFiCh/ain#1627 - To add more e2e related to `pagination` #### Which issue(s) does this PR fixes?: <!-- (Optional) Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes # #### Additional comments?: - Pending DeFiCh/ain#1689 to fix an issue where `start` is ignored when `status` is not passed OR when `cycle` is passed - However, this should not be a blocker for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind fix
What this PR does / why we need it:
When using filters like
cycleorstatusand passstartproposal id for pagination, it doesn't work correctly as it doesn't start from passed id. This PR solves it.