Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-chain governance fixes #1654

Merged
merged 12 commits into from
Dec 23, 2022
Merged

On-chain governance fixes #1654

merged 12 commits into from
Dec 23, 2022

Conversation

Jouzo
Copy link
Collaborator

@Jouzo Jouzo commented Dec 14, 2022

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

  • Remove proposalToJSON overwriting proposal status
  • Add proposal MAX_CYCLES to attributes

Mixa84
Mixa84 previously approved these changes Dec 16, 2022
@Jouzo Jouzo changed the title Fix getgovproposal status On-chain governance fixes Dec 23, 2022
@Bushstar Bushstar merged commit 6759c80 into master Dec 23, 2022
@Bushstar Bushstar deleted the fix/getgovproposal_status branch December 23, 2022 13:19
fuxingloh pushed a commit to BirthdayResearch/jellyfishsdk that referenced this pull request Dec 28, 2022
… behaviour (#1944)

<!--  Thanks for sending a pull request! -->

#### What this PR does / why we need it:

- Bump container version to latest master image
- Updates getGovProposal.test.ts to reflect fixes in
DeFiCh/ain#1654
Bushstar added a commit that referenced this pull request Jan 9, 2023
Bushstar added a commit that referenced this pull request Jan 9, 2023
* Move validation code to DeFi

* lint: circular deps

* lint: add local dep

* Update validation for #1654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants