Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor proposals related nomenclature #1634

Closed
wants to merge 4 commits into from
Closed

Refactor proposals related nomenclature #1634

wants to merge 4 commits into from

Conversation

prasannavl
Copy link
Member

/kind chore

  • Refactor all use cases of Prop to Proposal to be better descriptive, readable and less confusing.
  • Prop is a term that's commonly used to indicate property in a narrower context and is better not confused with proposals.

@Jouzo Jouzo added the v/3.2.1 label Dec 28, 2022
@prasannavl prasannavl removed the v/3.2.1 label Jan 5, 2023
@prasannavl
Copy link
Member Author

Closing in favor of #1687

@prasannavl prasannavl closed this Jan 13, 2023
@prasannavl prasannavl deleted the pvl/proposal-refactor branch April 10, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mixa84 Mixa84 Mixa84 approved these changes

@Jouzo Jouzo Jouzo approved these changes

@Bushstar Bushstar Awaiting requested review from Bushstar

@wafflespeanut wafflespeanut Awaiting requested review from wafflespeanut

Assignees

@prasannavl prasannavl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prasannavl @Jouzo @Mixa84 @defichain-bot