Revert change to stake modifier #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bushstar
requested review from
Mixa84,
wafflespeanut,
dcorral,
prasannavl,
mambisi and
Jouzo
as code owners
prasannavl
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes to the stake modifier made as part of the updatemasternode RPC call.
The original update masternode call allowed the operator address to the changed in a single block, as this was used as part of the stake modifier calculations this meant that an address could be pre-calculated that would allow the masternode to mint the next block and with another operator change the block after and so on. To combat this we changed the stake modifier to use the owner address instead.
Since that time we added the ability to change the owner address, but added a 1,008 block wait time before the change came into effect, making the stake modifier change redundant.