Poolswap to empty to address swaps to from address making to optional #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bushstar
requested review from
Mixa84,
wafflespeanut,
dcorral,
prasannavl,
mambisi and
Jouzo
as code owners
kuegi
reviewed
Nov 1, 2022
prasannavl
changed the title
prasannavl
changed the title
Bushstar
changed the title
prasannavl
previously approved these changes
Nov 11, 2022
src/masternodes/mn_checks.cpp
Outdated
| @@ -4355,7 +4355,7 @@ Res CPoolSwap::ExecuteSwap(CCustomCSView& view, std::vector<DCT_ID> poolIDs, boo | |||
| intermediateView.Flush(); | |||
|
|
|||
| auto& addView = lastSwap ? view : intermediateView; | |||
| res = addView.AddBalance(lastSwap ? obj.to : obj.from, swapAmountResult); | |||
| res = addView.AddBalance(lastSwap ? (obj.to.empty() && height >= static_cast<uint32_t>(Params().GetConsensus().GrandCentralHeight) ? obj.from : obj.to) : obj.from, swapAmountResult); | |||
There was a problem hiding this comment.
Suggested change
| res = addView.AddBalance(lastSwap ? (obj.to.empty() && height >= static_cast<uint32_t>(Params().GetConsensus().GrandCentralHeight) ? obj.from : obj.to) : obj.from, swapAmountResult); | |
| if (height >= static_cast<uint32_t>(Params().GetConsensus().GrandCentralHeight)) { | |
| res = addView.AddBalance(lastSwap ? (obj.to.empty() ? obj.from : obj.to) : obj.from, swapAmountResult); | |
| } else { | |
| res = addView.AddBalance(lastSwap ? obj.to : obj.from, swapAmountResult); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When failing to set an address on a pool swap the swapped amount is sent to the from address, not an empty inaccessible address.