Allow payback of DUSD with vault's collateral #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jouzo
requested review from
uzyn,
Bushstar,
Mixa84,
surangap,
wafflespeanut,
dcorral,
prasannavl and
mambisi
as code owners
|
TODO:
Looks good otherwise. |
kuegi
reviewed
Sep 9, 2022
src/masternodes/mn_checks.cpp
Outdated
| return Res::Err("tx must have at least one input from token owner"); | ||
|
|
||
| if (!IsVaultPriceValid(mnview, obj.vaultId, height)) | ||
| return Res::Err("Cannot payback vault with collateral while any of the asset's price is invalid"); |
There was a problem hiding this comment.
why not? we can always payback loans with same coin, cause no oracle price needed.
There was a problem hiding this comment.
Let me answer this on the main comments for better visibility later.
kuegi
reviewed
Sep 9, 2022
|
It's currently not possible to get some information over the RPC about what's really happening in the vault, right? It would be nice to get an entry in the listvaulthistory. Is this what @prasannavl means with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Allow payback of DUSD with vault's collateral