Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DFI DUSD vault collateral requirement rules #1450

Merged
merged 41 commits into from
Sep 12, 2022

Conversation

dcorral
Copy link
Contributor

@dcorral dcorral commented Sep 8, 2022

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Force 50% DFI collateral on vaults with DUSD loan

src/masternodes/mn_checks.cpp Outdated Show resolved Hide resolved
@prasannavl prasannavl changed the title FCE 50% collateral checks WIP: FCE 50% collateral checks Sep 9, 2022
@prasannavl prasannavl changed the title WIP: FCE 50% collateral checks [WIP] FCE 50% collateral checks Sep 9, 2022
src/masternodes/mn_checks.cpp Outdated Show resolved Hide resolved
@prasannavl prasannavl changed the title [WIP] FCE 50% collateral checks FCE 50% collateral checks Sep 10, 2022
@prasannavl prasannavl changed the title FCE 50% collateral checks Update DFI DUSD vault requirement rules Sep 10, 2022
@prasannavl prasannavl changed the title Update DFI DUSD vault requirement rules Update DFI DUSD vault collateral requirement rules Sep 10, 2022
@prasannavl prasannavl merged commit 12eae63 into master Sep 12, 2022
@prasannavl prasannavl deleted the pvl/fce-no-dusd-loop branch September 12, 2022 03:55
@BenTStark
Copy link

If you want to mint dTokens and DUSD, you need two vaults to get the same effect as before. Wouldn't it be easier from a user's perspective to evaluate Loans and Collaterals in mn_checks.cpp?
DUSD Loan has to be backed fully by DFI. Then all other loans must be backed by DFI and DUSD.

@kuegi
Copy link
Contributor

kuegi commented Sep 16, 2022

If you want to mint dTokens and DUSD, you need two vaults to get the same effect as before. Wouldn't it be easier from a user's perspective to evaluate Loans and Collaterals in mn_checks.cpp? DUSD Loan has to be backed fully by DFI. Then all other loans must be backed by DFI and DUSD.

you do not need 2 vaults. DUSD loan doesn't have to be backed fully by DFI. Its just that as soon as you have DUSD loans in the vault, 50% of your required collateral needs to be DFI.
Only reason to have two vaults is if you want one 100% DUSD vault where you mint dToken, and one (smaller, otherwise you can combine them) vault with DFI where you mint DUSD. But then I ask the question why you would mint DUSD in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants