Add logstoredinterests
#1429
Add logstoredinterests
#1429
Conversation
prasannavl
requested review from
uzyn,
Bushstar,
Mixa84,
surangap,
wafflespeanut,
dcorral,
mambisi and
Jouzo
as code owners
|
|
||
| auto height = ::ChainActive().Height(); | ||
| using VaultInfo = std::tuple<DCT_ID,CAmount,CInterestRateV3>; | ||
| std::map<std::string, std::vector<VaultInfo>> items; |
There was a problem hiding this comment.
Why not add directly to UniValue and avoid iterating again after?
There was a problem hiding this comment.
Unless there is a specific reason to do so, I'd highly recommend against doing that. The extra memory by the raw dataset, compared to UniValue is usually small. And so is the additional computation that they are irrelevant. Code clarity, reusability and maintenance is usually far more important to focus on. This decouples the formatting from the actual logic.
In other words, now the logic is unit-testable, apart from the formatting.
Second, the format could something else that's not JSON at all (GRPC, for instance). Mixing it up with UniValue makes things messy.
Performance aspects if it ever is a concern (unlikely in these cases), having clear separation of concerns also provides opportunities to parallelize the logic, etc. if needed. Getting UniValue will make that messy as well.
/kind feature