Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert back to BR socket code instead of poll based BTC socket #1408

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Revert back to BR socket code instead of poll based BTC socket #1408

merged 2 commits into from
Aug 3, 2022

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Aug 3, 2022 •
edited
Loading

/kind fix

  • Revert back to the Bread Wallet SPV socket connect code for now.
  • The BTC socket socket code results in high CPU (possibly due to the incompatibility between the socket creation mechanisms - one uses poll and the other select - further investigation required)

@prasannavl prasannavl merged commit a9b4d61 into master Aug 3, 2022
@prasannavl prasannavl deleted the fix/br_socket branch August 3, 2022 16:17
@prasannavl prasannavl changed the title Revert back to BR socket code instead of async BTC socket Revert back to BR socket code instead of poll based BTC socket Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzyn uzyn Awaiting requested review from uzyn

@Bushstar Bushstar Awaiting requested review from Bushstar

@Mixa84 Mixa84 Awaiting requested review from Mixa84

@surangap surangap Awaiting requested review from surangap

Assignees

@prasannavl prasannavl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasannavl @defichain-bot