Prevent transactions in blocks from going below balance. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bushstar
force-pushed
the
account-mining-solution
branch
from
fed3155 to
932a670
Compare
| assert_equal(node.getblockcount(), blockcount + 1) | ||
|
|
||
| # Account should now be empty | ||
| assert_equal(node.getaccount(account), []) |
There was a problem hiding this comment.
Can also check the count of transactions?
There was a problem hiding this comment.
I'll add it. We would expect five TXs in the block plus coinbase. This test will also be extended to include other account TXs.
| bool accountConflict{false}; | ||
|
|
||
| // Check if any custom TXs are in mempool with conflict | ||
| for (indexed_transaction_set::const_iterator it = mapTx.begin(); it != mapTx.end(); ++it) { |
There was a problem hiding this comment.
Use auto instead of indexed_transaction_set::const_iterator
| CAmount txfee = 0; | ||
|
|
||
| // Check custom TX consensus types are now not in conflict with account layer | ||
| for (indexed_transaction_set::const_iterator it = mapTx.begin(); it != mapTx.end(); ++it) { |
There was a problem hiding this comment.
Use auto instead of indexed_transaction_set::const_iterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks changes to account when including transactions in a blocks, this prevents an account trying to spend more than it has which is an invalid state and would be rejected. After block creation some transactions left in the mempool may then be invalid due to our bespoke account layer, we iterate over the mempool and remove any transactions that fail CheckTxInputs.