Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Boost Thread and Chrono #1349

Merged
merged 15 commits into from
Jul 11, 2022
Merged

Remove Boost Thread and Chrono #1349

merged 15 commits into from
Jul 11, 2022

Conversation

Bushstar
Copy link
Member

No description provided.

@prasannavl
Copy link
Member

Moving to v3 for additional testing.

Main concern: ShutdownRequested breaking early loops early esp (inside storage iterations right now has the potential to result in incorrect behaviour without a clean propagation mechanism of early exists)

@Bushstar Bushstar merged commit 40d2fda into master Jul 11, 2022
@Bushstar Bushstar deleted the remove-thread-master branch July 11, 2022 10:55
Bushstar added a commit that referenced this pull request Jul 25, 2022
* Remove boost::chrono and boost::sleep

* Remove Boost mutex

* Remove Boost thread_group

* Remove Boost thread/mutex from SPV

* Remove Boost interruption_point

* Replace Boost shared_mutex with C++17 std::shared_mutex

* Remove Boost Chrono and Thread from build system

* Add missing include

* Remove duplicate start of scheduler thread

* Remove Boost case_conv

* Remove Boost join and transformed

* Do not interrupt ForEach loop

* Add notes to interrupt replacements

Co-authored-by: Prasanna Loganathar <[email protected]>
prasannavl added a commit that referenced this pull request Jul 25, 2022
* Remove boost::chrono and boost::sleep

* Remove Boost mutex

* Remove Boost thread_group

* Remove Boost thread/mutex from SPV

* Remove Boost interruption_point

* Replace Boost shared_mutex with C++17 std::shared_mutex

* Remove Boost Chrono and Thread from build system

* Add missing include

* Remove duplicate start of scheduler thread

* Remove Boost case_conv

* Remove Boost join and transformed

* Do not interrupt ForEach loop

* Add notes to interrupt replacements

Co-authored-by: Prasanna Loganathar <[email protected]>

Co-authored-by: Prasanna Loganathar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants