-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versionSuffix getversioninfo #1339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into ain_add_suffix_getversioninfo
… into ain_add_suffix_getversioninfo
dcorral
requested review from
wafflespeanut,
prasannavl,
mambisi and
Jouzo
as code owners
September 5, 2022 08:47
dcorral
changed the title
[WIP] Add suffix getversioninfo
Add versionSuffix getversioninfo
Sep 5, 2022
Jouzo
previously approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference :
On master :
defi-cli getversioninfo
{
"name": "DeFiChain",
"version": "2.11.1",
"numericVersion": 2110100,
"fullVersion": "DeFiChain:2.11.1",
"userAgent": "/DeFiChain:2.11.1/",
"protoVersion": 70030,
"protoVersionMin": 70023,
"rpcVersion": "1",
"rpcVersionMin": "1",
"spv": {
"btc": {
"version": 70013,
"min": 70002,
"userAgent": "/bread:2.1/"
}
}
}
With this change :
defi-cli getversioninfo
{
"name": "DeFiChain",
"version": "2.10.0",
"versionSuffix": "ain_add_suffix_getversioninfo-e59bf32fc",
"numericVersion": 2100000,
"fullVersion": "DeFiChain:v2.10.0.0-ain_add_suffix_getversioninfo-e59bf32fc",
"userAgent": "/DeFiChain:2.10.0/",
"protoVersion": 70030,
"protoVersionMin": 70023,
"rpcVersion": "1",
"rpcVersionMin": "1",
"spv": {
"btc": {
"version": 70013,
"min": 70002,
"userAgent": "/bread:2.1/"
}
}
}
prasannavl
added a commit
that referenced
this pull request
Nov 12, 2022
This reverts commit 534a916.
prasannavl
added a commit
that referenced
this pull request
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind fix
What this PR does / why we need it:
Adds version suffix to
getversioninfo
rpc.WIP:
Investigate build error on previous work.