Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versionSuffix getversioninfo #1339

Merged
merged 20 commits into from
Nov 11, 2022
Merged

Conversation

dcorral
Copy link
Contributor

@dcorral dcorral commented Jun 9, 2022

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

Adds version suffix to getversioninfo rpc.

WIP:
Investigate build error on previous work.

@dcorral dcorral marked this pull request as draft June 10, 2022 00:00
@dcorral dcorral marked this pull request as ready for review September 5, 2022 08:47
@dcorral dcorral changed the title [WIP] Add suffix getversioninfo Add versionSuffix getversioninfo Sep 5, 2022
@dcorral dcorral changed the base branch from master to epic/grandcentral October 4, 2022 08:32
Jouzo
Jouzo previously approved these changes Oct 20, 2022
Copy link
Collaborator

@Jouzo Jouzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference :
On master :

defi-cli getversioninfo
{
  "name": "DeFiChain",
  "version": "2.11.1",
  "numericVersion": 2110100,
  "fullVersion": "DeFiChain:2.11.1",
  "userAgent": "/DeFiChain:2.11.1/",
  "protoVersion": 70030,
  "protoVersionMin": 70023,
  "rpcVersion": "1",
  "rpcVersionMin": "1",
  "spv": {
    "btc": {
      "version": 70013,
      "min": 70002,
      "userAgent": "/bread:2.1/"
    }
  }
}

With this change :

defi-cli getversioninfo
{
  "name": "DeFiChain",
  "version": "2.10.0",
  "versionSuffix": "ain_add_suffix_getversioninfo-e59bf32fc",
  "numericVersion": 2100000,
  "fullVersion": "DeFiChain:v2.10.0.0-ain_add_suffix_getversioninfo-e59bf32fc",
  "userAgent": "/DeFiChain:2.10.0/",
  "protoVersion": 70030,
  "protoVersionMin": 70023,
  "rpcVersion": "1",
  "rpcVersionMin": "1",
  "spv": {
    "btc": {
      "version": 70013,
      "min": 70002,
      "userAgent": "/bread:2.1/"
    }
  }
}

@dcorral dcorral changed the base branch from epic/grandcentral to master November 7, 2022 06:51
@dcorral dcorral dismissed Jouzo’s stale review November 7, 2022 06:51

The base branch was changed.

@prasannavl prasannavl merged commit 534a916 into master Nov 11, 2022
@prasannavl prasannavl deleted the ain_add_suffix_getversioninfo branch November 11, 2022 17:01
prasannavl added a commit that referenced this pull request Nov 12, 2022
prasannavl added a commit that referenced this pull request Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants