Return -1 value on getvault when tokens are locked #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functional tests.
…to fix-return-on-locked-token
Bushstar
reviewed
May 31, 2022
| @@ -141,6 +142,14 @@ namespace { | |||
| collateralRatio = int(rate.val->ratio()); | |||
| } | |||
|
|
|||
| bool isVaultTokenLocked {false}; | |||
| for (const auto& collateral : collaterals->balances) { | |||
There was a problem hiding this comment.
Vault will only lock on a loan token being split.
There was a problem hiding this comment.
Good call out. Should be harmless for now.
Bushstar
approved these changes
May 31, 2022
prasannavl
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind fix
What this PR does / why we need it:
Make
getvaultreturn -1 values instead of 0 when any of the tokens in the vault is frozen.Added functional tests.