Add legacy filtering mode #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasannavl
requested review from
uzyn,
Bushstar,
Mixa84 and
surangap
as code owners
Bushstar
force-pushed
the
feature/attrs_impl_legacy
branch
from
298e44d to
d4f58fb
Compare
prasannavl
commented
May 24, 2022
|
Once "attrs" are used. It changes the index. Need to adapt. |
|
The change appear to have been reverted in the penultimate commit. Added the correct fix, which is to change the index. Also change defaults and added a bit more. |
prasannavl
force-pushed
the
feature/attrs_impl_legacy
branch
from
a0df6ea to
53b45b8
Compare
Bushstar
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature