Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of totalAuctions in getloaninfo RPC #1124

Merged
merged 6 commits into from
Mar 18, 2022
Merged

Fix number of totalAuctions in getloaninfo RPC #1124

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d2b435
Fix number of totalAuctions in getloaninfo
Jouzo Mar 1, 2022
033da13
Remove use of GetAuction
Jouzo Mar 4, 2022
d932ac7
Add tests
Jouzo Mar 4, 2022
54db210
Merge branch 'master' into fix/getloaninfodata
Jouzo Mar 7, 2022
7b0ec3f
Merge branch 'master' into fix/getloaninfodata
prasannavl Mar 18, 2022
695f624
Merge branch 'master' into fix/getloaninfodata
prasannavl Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/masternodes/rpc_loan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,7 +1288,7 @@ UniValue getloaninfo(const JSONRPCRequest& request) {
});

pcustomcsview->ForEachVaultAuction([&](const CVaultId& vaultId, const CAuctionData& data) {
totalAuctions++;
totalAuctions += data.batchCount;
return true;
}, height);

Expand Down
3 changes: 3 additions & 0 deletions test/functional/feature_loan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ def run_test(self):
assert_equal(len(auctionlist[0]['batches']), 3)
vault1 = self.nodes[0].getvault(vaultId1)

getloaninfo = self.nodes[0].getloaninfo()
assert_equal(getloaninfo['totals']['openAuctions'], 3)

# Fail auction bid
try:
self.nodes[0].placeauctionbid(vaultId1, 0, account, "410@TSLA")
Expand Down