Resolve mempool segfault #1061
Merged
Resolve mempool segfault #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bushstar
requested review from
bvbfan,
Mixa84,
monstrobishi,
surangap and
uzyn
as code owners
bvbfan
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to resolve mempool segfault when mempool.clear() is called. I believe that this is an issue upstream in Bitcoin but their usage of clear() does not result in any issues. We have additional uses including clearmempool which is used in the test, without this fix the test will result in a node crashing. The fix is to clear vTxHashes after mapTx is cleared, vTxHashes is a vector of all entries in mapTx so this seems reasonable, otherwise a TX iterator in vTxHashes might be used resulting in a segfault.