Smart contract exchange of BTC for DFI #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bushstar
requested review from
bvbfan,
Mixa84,
monstrobishi,
surangap and
uzyn
as code owners
bvbfan
reviewed
Jan 19, 2022
| @@ -243,6 +243,9 @@ class CMainParams : public CChainParams { | |||
| consensus.accountDestruction.insert(GetScriptForDestination(DecodeDestination("dJEbxbfufyPF14SC93yxiquECEfq4YSd9L", *this))); | |||
| consensus.accountDestruction.insert(GetScriptForDestination(DecodeDestination("8UAhRuUFCyFUHEPD7qvtj8Zy2HxF5HH5nb", *this))); | |||
|
|
|||
| consensus.smartContracts.clear(); | |||
| consensus.smartContracts["DFIP2201"] = GetScriptForDestination(CTxDestination(WitnessV0KeyHash(std::vector<unsigned char>{0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0}))); | |||
There was a problem hiding this comment.
Can we use std::vector<unsigned char>(20, 0) {} - it's initializer_list
There was a problem hiding this comment.
For this leave it in full, next smart contract address will be copy and paste of this with 1 set at the end.
There was a problem hiding this comment.
May be we use something like a boost preprocessor macro to update in compile time and let that increment later. For now copy paste looks to do.
bvbfan
approved these changes
Jan 19, 2022
kuegi
reviewed
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.