Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject block that contains unsupported custom txs #1018

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

bvbfan
Copy link
Contributor

@bvbfan bvbfan commented Jan 3, 2022

/kind fix

@bvbfan bvbfan force-pushed the fix/interruptable_revert branch from 0e81ea9 to 1342c12 Compare January 3, 2022 17:13
@prasannavl prasannavl merged commit f1ac2be into master Jan 3, 2022
@prasannavl prasannavl deleted the fix/interruptable_revert branch January 3, 2022 17:46
@dell1503
Copy link

dell1503 commented Jan 3, 2022

I dont understand this
Commit.
So there is after the last update a block produced by a faulty Masternode?
But this means we have an issue with the MN as well?
Thanks for explanation.

@prasannavl prasannavl changed the title Reject block that contains custom tx produced by incorrect masternode Reject block that contains unsupported custom txs Jan 3, 2022
@prasannavl
Copy link
Member

prasannavl commented Jan 3, 2022

So there is after the last update a block produced by a faulty Masternode?

No.

But this means we have an issue with the MN as well?

Disabled or unsupported TXs (say, ICX TX submitted from a 2.3.x node to the 2.4.x MN which considers it invalid due to being disabled) causes the MN to rollback excessively, which stalls the blockchain when all miners end up in many rollbacks. This commit provides better behaviour for TXs that's considered invalid by the current protocol (say, 2.4.x/2.5.x).

@dell1503
Copy link

dell1503 commented Jan 4, 2022

So there is after the last update a block produced by a faulty Masternode?

No.

But this means we have an issue with the MN as well?

Disabled or unsupported TXs (say, ICX TX submitted from a 2.3.x node to the 2.4.x MN which considers it invalid due to being disabled) causes the MN to rollback excessively, which stalls the blockchain when all miners end up in many rollbacks. This commit provides better behaviour for TXs that's considered invalid by the current protocol (say, 2.4.x/2.5.x).

Than you for explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants