util: Remove obsolete check in addr conversions (#2608)

* rpc: addressmap: Better error messages * rpc: addressmap: add erc55 validity check * Add const * util: Remove obsolete check --------- Co-authored-by: Peter John Bushnell <[email protected]>
DeFiCh · Oct 23, 2023 · e599f2f · e599f2f
1 parent 8597e7d
commit e599f2f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/rpc/util.cpp b/src/rpc/util.cpp
@@ -158,9 +158,6 @@ CPubKey AddrToPubKey(FillableSigningProvider* const keystore, const std::string&
     if (!keystore->GetPubKey(key, vchPubKey)) {
         throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("no full public key for address %s", addr_in));
     }
-    if (dest.index() == WitV16KeyEthHashType && vchPubKey.IsCompressed()) {
-        throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("no valid public key for address %s", addr_in));
-    }
     if (!vchPubKey.IsFullyValid()) {
        throw JSONRPCError(RPC_INTERNAL_ERROR, "Wallet contains an invalid public key");
     }

diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -4322,7 +4322,7 @@ UniValue addressmap(const JSONRPCRequest &request) {
             if (key.IsCompressed()) {
                 key.Decompress();
             }
-            auto erc55 = EncodeDestination(WitnessV16EthHash(key));
+            const auto erc55 = EncodeDestination(WitnessV16EthHash(key));
             // Check if it's in the wallet. 
             // Note: Can be removed if the full wallet is migrated.
             // Ref: https://github.com/DeFiCh/ain/issues/2604