Fix pool id serialization in update poolpair tx

Signed-off-by: Anthony Fieroni <[email protected]>
DeFiCh · Mar 29, 2021 · 96e675e · 96e675e
1 parent 278f973
commit 96e675e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/masternodes/mn_checks.cpp b/src/masternodes/mn_checks.cpp
@@ -255,7 +255,8 @@ class CCustomMetadataParseVisitor : public boost::static_visitor<Res>
         }
 
         CDataStream ss(metadata, SER_NETWORK, PROTOCOL_VERSION);
-        ss >> obj.poolId;
+        // serialize poolId as raw integer
+        ss >> obj.poolId.v;
         ss >> obj.status;
         ss >> obj.commission;
         ss >> obj.ownerAddress;

diff --git a/src/masternodes/rpc_poolpair.cpp b/src/masternodes/rpc_poolpair.cpp
@@ -713,7 +713,8 @@ UniValue updatepoolpair(const JSONRPCRequest& request) {
 
     CDataStream metadata(DfTxMarker, SER_NETWORK, PROTOCOL_VERSION);
     metadata << static_cast<unsigned char>(CustomTxType::UpdatePoolPair)
-             << poolId << status << commission << ownerAddress;
+             // serialize poolId as raw integer
+             << poolId.v << status << commission << ownerAddress;
 
     if (targetHeight >= Params().GetConsensus().ClarkeQuayHeight) {
         metadata << rewards;
@@ -741,7 +742,7 @@ UniValue updatepoolpair(const JSONRPCRequest& request) {
         CCoinsViewCache coins(&::ChainstateActive().CoinsTip());
         if (optAuthTx)
             AddCoins(coins, *optAuthTx, targetHeight);
-        auto metadata = ToByteVector(CDataStream{SER_NETWORK, PROTOCOL_VERSION, poolId, status, commission, ownerAddress});
+        auto metadata = ToByteVector(CDataStream{SER_NETWORK, PROTOCOL_VERSION, poolId.v, status, commission, ownerAddress});
         execTestTx(CTransaction(rawTx), targetHeight, metadata, CUpdatePoolPairMessage{}, coins);
     }
     return signsend(rawTx, pwallet, optAuthTx)->GetHash().GetHex();