Fix number of totalAuctions in getloaninfo RPC (#1124)

* Fix number of totalAuctions in getloaninfo * Remove use of GetAuction * Add tests Co-authored-by: Prasanna Loganathar <[email protected]>
DeFiCh · Mar 18, 2022 · 2419f51 · 2419f51
1 parent 4d10561
commit 2419f51
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/masternodes/rpc_loan.cpp b/src/masternodes/rpc_loan.cpp
@@ -1288,7 +1288,7 @@ UniValue getloaninfo(const JSONRPCRequest& request) {
     });
 
     pcustomcsview->ForEachVaultAuction([&](const CVaultId& vaultId, const CAuctionData& data) {
-        totalAuctions++;
+        totalAuctions += data.batchCount;
         return true;
     }, height);
 

diff --git a/test/functional/feature_loan.py b/test/functional/feature_loan.py
@@ -135,6 +135,9 @@ def run_test(self):
         assert_equal(len(auctionlist[0]['batches']), 3)
         vault1 = self.nodes[0].getvault(vaultId1)
 
+        getloaninfo = self.nodes[0].getloaninfo()
+        assert_equal(getloaninfo['totals']['openAuctions'], 3)
+
         # Fail auction bid
         try:
             self.nodes[0].placeauctionbid(vaultId1, 0, account, "410@TSLA")