Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Private API Gateway #1

Closed
wants to merge 1 commit into from
Closed

Conversation

haowjern
Copy link

@haowjern haowjern commented Jul 8, 2020

Overview

Added new configuration, inputs and outputs to allow us to create a Private API Gateway.

Proposed changes

  • Add an IAM policy to be used when a private API is specified
    • At the moment, I can't update the policy to operate on specific resources because of the below reasons, so I have instead defined it to operate on all resource paths (which should be OK anyways)
      • Private API Gateway requires a 'policy' input, but I want to use this api gateway's ARN in the policy, but I can only get that once it is deployed, so there's a cyclic dependency here.
      • There's an open issue that might see changes introduced to fix this.
  • Add configuration, inputs and outputs.

Notes

  • This works in DEV, I'm able to create and connect to the private API Gateway

Tickets

  • [SL-696]

Checklist

  • Clear title such as "Feature: ..." or "Fix: ..." or other
  • Clear and descriptive overview explaining why this change is needed
  • List of changes proposed in this pull request (short bullet points)
  • List of related changes such as external diffs, related releases or other
  • Additional notes that would help the reviewers approve more quickly and with confidence

modules/apigw/outputs.tf Outdated Show resolved Hide resolved
modules/apigw/main.tf Outdated Show resolved Hide resolved
modules/apigw/main.tf Outdated Show resolved Hide resolved
modules/apigw/outputs.tf Outdated Show resolved Hide resolved
modules/apigw/variables.tf Outdated Show resolved Hide resolved
Copy link

@crixey crixey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me

modules/apigw/outputs.tf Outdated Show resolved Hide resolved
@haowjern haowjern closed this Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants