Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move capacitor and kysely to peer dependencies #2

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

a-type
Copy link
Contributor

@a-type a-type commented Oct 30, 2024

I did not upgrade this repo's dependencies, just moved them to devdeps.

However, I did specify more lax ranges for peer deps. AFAIK there are no breaking changes which would affect this library on more recent versions of either dependency. However, the >= range means any future versions as well, idk if it's ideal.

Copy link
Contributor Author

@a-type a-type left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: also refactored types to be included in build output. Previously the built library did not include any of the 'ambient' types defined in types/types.d.ts, meaning things like initialization options have to typechecking for users.

@DawidWetzler DawidWetzler merged commit eafe500 into DawidWetzler:main Nov 7, 2024
@DawidWetzler
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants